[chip,dv] flash_ctrl memory protection test #20800
Conversation
jdonjdon
requested review from
hcallahan-lowrisc,
jon-flatley,
moidx,
timothytrippel and
matutem
and removed request for
a team
jdonjdon
force-pushed
the
flash_protection
branch
from
fe32f4f to
2bfcf2a
Compare
| * FLASH_CTRL memory protection test | ||
| * | ||
| * This test checks multiple memory protection regions and priority in case | ||
| * any regions are overrapped. |
There was a problem hiding this comment.
| * any regions are overrapped. | |
| * any regions overlap. |
| &flash, /*rd_en=*/true, /*prog_en=*/true, /*erase_en=*/true, | ||
| /*scramble_en=*/false, /*ecc_en=*/false, /*high_endurance_en=*/false)); | ||
|
|
||
| for (int i = 2; i >= 0; i--) { |
There was a problem hiding this comment.
I am curious: should the test have two loops here, one that sets all region properties, and another one that does test_mem_access? This way test_mem_access will be certain to run with properties set as described above.
There was a problem hiding this comment.
Each loop it programs table entry)
to cover multiple MP regions.
There was a problem hiding this comment.
I think I understand: each time you create a new region overlapping previous regions starting at a lower page, so it has higher priority. If you agree this is how it works, please change the text around line 34 to reflect this.
There was a problem hiding this comment.
@matutem , test program higher region first, which has "lower" priority.
Then subsequent programming with lower region will overruled previous config parameter because
lower region number has "higher" priority.
jdonjdon
force-pushed
the
flash_protection
branch
from
2bfcf2a to
ecf5e43
Compare
Test for multi mp region and their priority. Test verified in simulation platform. sival target will be added in the subsequent PR. Signed-off-by: Jaedon Kim <[email protected]>
jdonjdon
force-pushed
the
flash_protection
branch
from
ecf5e43 to
fb05a7a
Compare
Thanks, @matutem Comment has been updated as suggested. |
Test for flash_ctrl multi mp regions and their priority.
Test verified in simulation platform.
sival target will be added in the subsequent PR.